Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci compute update #149

Closed
wants to merge 1 commit into from
Closed

Ci compute update #149

wants to merge 1 commit into from

Conversation

gq1
Copy link
Member

@gq1 gq1 commented Oct 14, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@gq1
Update sanger_test_full.yml
947706f 
Not use the default compute environment to run the full CI test on farm
@gq1 gq1 changed the base branch from main to dev October 14, 2024 09:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 947706f

+| ✅ 131 tests passed       |+
#| ❔  21 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-genomenote_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-genomenote_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-genomenote_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: conf/igenomes.config
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File does not exist: assets/nf-core-genomenote_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-genomenote_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-genomenote_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/genomenote/genomenote/.github/workflows/awstest.yml
  • template_strings - template_strings

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2024-10-14 09:25:32

@gq1 gq1 requested a review from muffato October 14, 2024 09:29
@gq1
Copy link
Member Author

gq1 commented Oct 14, 2024

https://cloud.seqera.io/orgs/sanger-tol/workspaces/github-ci/watch/5VUhThWsZpmaJm
The job completed successfully now.

@muffato
Copy link
Member

muffato commented Oct 14, 2024

Oki, thanks. In that case, to avoid the risk of other pipelines failing for the same reason. Should we apply the plan you discussed last time ? i.e. change the TOWER_COMPUTE_ENV value to point at the 4 GB environment.
That way, all pipelines are changed at once.

From the perspective of compute efficiency, I'd be OK with that because it is justified and limited (there aren't that many Tower jobs coming through)

@gq1
Copy link
Member Author

gq1 commented Oct 14, 2024

Oki, thanks. In that case, to avoid the risk of other pipelines failing for the same reason. Should we apply the plan you discussed last time ? i.e. change the TOWER_COMPUTE_ENV value to point at the 4 GB environment. That way, all pipelines are changed at once.

Yes, can you update? And then we can close this PR and delete the new repo level secret I added this morning.

@muffato
Copy link
Member

muffato commented Oct 14, 2024

Changed.
At the same time I've renamed the environments in Tower to be explicit about the RAM (rather than "small", "large")

@gq1
Copy link
Member Author

gq1 commented Oct 14, 2024

Repo level secret deleted and no action for this PR itself.

@gq1 gq1 closed this Oct 14, 2024
@muffato muffato deleted the ci_compute branch November 4, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muffato muffato Awaiting requested review from muffato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gq1 @muffato